-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improve appsignal to support tagging #2
Merged
hieuk09
merged 8 commits into
Kaligo:master
from
Vuta:feature/improve_appsignal_to_support_tagging
Nov 15, 2020
Merged
Feature/improve appsignal to support tagging #2
hieuk09
merged 8 commits into
Kaligo:master
from
Vuta:feature/improve_appsignal_to_support_tagging
Nov 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dfa6c8
to
f54f0b0
Compare
hieuk09
reviewed
Oct 6, 2020
@Vuta could you bump the gem to 0.1.3. The changes look good to me. |
sylv3rblade
reviewed
Oct 15, 2020
@Vuta can u help to update this branch to incl. 0.2? I'll help to review the GH logs too |
hieuk09
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- tag is collected correctly
@Vuta could you bump this gem to 0.2.1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
We want to improve Appsignal logging by using tags for metric
design
value
andtags
key), else returns failure result.test cases
EventTracer.info action: 'Action', message: 'Message', appsignal: { increment_counter: { counter_1: 1, counter_2: 2 } }
works as usual{ name: { value: value, tags: hash } }
Example:
value
andtags
)