Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the SUPER type for JSONB type in the source [LOYAL-10940] #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quocnguyendinh
Copy link

@quocnguyendinh quocnguyendinh commented Jul 2, 2024

https://kaligo.atlassian.net/browse/LOYAL-10940

Background

  • We’re replicating Postgres JSONB as Redshift VARCHAR and convert them at staging layer
  • By default, we need to convert VARCHAR to SUPER type in Redshift via PARSE_JSON(...). Instead, we can move this from T to EL part (embedded into Target-Redshift).

Design

Tune the codebase in order to enable convert Postgres JSONB column into Redshift SUPER type.

Impact

No need to worry about new tables with JSONB columns and also save more resource since we no longer use PARSE_JSON(...) on top of view in the original way.

Caveats

None

Testing

  • Setup the Python Virtual Environment based on the requirements.txt
  • Run coverage run -m pytest -vv --disable-pytest-warnings tests/unit && coverage report to check the unit tests:
    Screenshot 2024-07-02 at 15 57 55 (2)

Docs

None

@quocnguyendinh quocnguyendinh added the ready to review Code has been added/fixed and is ready to review label Jul 2, 2024
@quocnguyendinh quocnguyendinh self-assigned this Jul 2, 2024
Copy link

@khoaanguyenn khoaanguyenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review Code has been added/fixed and is ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants