Skip to content

Fixes #38186 - Debian support for new All Hosts packages wizard #11371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nadjaheitmann
Copy link
Contributor

What are the changes introduced in this pull request?

As of now, the Packages Wizard on the new All Hosts page only supports yum type packages but no deb type packages. This is changed with this PR.

Considerations taken when implementing this change?

The current implementation does not take into account CVEs of the hosts at all. I added two different warnings in case there is a mismatch (for all actions except the 'Update all packages' action as that one is generic):

  1. The hosts are not in the same OS family. This is a major problem as Debs and RPMs talk to different APIs to request packages. Hence, the user needs to make changes to the host selection to proceed with package selection.
  2. The hosts are in the same OS family but not in the same CVE. A warning is shown but the user can still select packages and continue with the desired action.

Screenshot for 1)
image

Screenshot for 2)
image

One open besides open test coverage is multi CV support. Any input on this is appreciated.

What are the testing steps for this pull request?

You need three hosts of with three different CVEs and at least one of them should be of OS family Debian.

Co-authored-by: Thorben Denzer <denzeratix.de>
@nadjaheitmann nadjaheitmann force-pushed the 38186_debian_support_package_wizard branch from 5a9f980 to 51a2f7e Compare April 14, 2025 09:06
Comment on lines +100 to +101
hostsBulkSelect?.hostsResponse?.response?.results?.filter(host =>
!hostsBulkSelect.hostsBulkSelect.exclusionSet.has(host.id));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't rely on exclusionSet, as it's only populated when you're in "select all mode" (e.g. you've used the Select All checkbox and then deselected some items.) Instead, I think the best we can do is

for "Regular" mode: Rely on selectedResults and selectedCount. selectedResults contains all the data from each selected item (provided that selectOne is passed properly to tableIndexPage with the data argument), so you can look at OS family there.

For "Select all" mode: When answering the question "Is there an OS family mismatch?" the best we can do is "I don't know." So we may want an Info-level banner, or just to add a disclaimer to the text at the top, similar to what we did on the host review page in #11361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants