New Feature for custom style injection #69
Conversation
Added new prop "styles" which allow the developer to inject classes names to the following selectors: vueSimpleSuggest inputWrapper defaultInput suggestions suggestItem This with the "destyled" prop allow the user to use css frameworks like Bootstrap more easily.
Added new prop "styles" which allow the developer to inject classes names to the following selectors: vueSimpleSuggest inputWrapper defaultInput suggestions suggestItem This with the "destyled" prop allow the user to use css frameworks like Bootstrap more easily.
There was a problem hiding this comment.
@rcostalenz, this is a great feature, actualy. Thank you for your contribution :)
Just a minute ago I wanted to add a remark to suggestItem class, but you've already fixed it :D
@Raiondesu any comments?
|
I agree with @kaskar2008, the feature is great overall. |
Raiondesu
added
good first issue
|
Fix it! I am glad you guys like it. |
|
@rcostalenz, @Raiondesu I think it can't be done that way because |
|
And I think those misc items can also be not a single element tho. |
|
@kaskar2008 Hmm |
|
@kaskar2008 This got me thinking now |
This reverts commit f3fe617.
|
Actually, since slot can be fully customizable with templates there is no reason to have those, I remove them |
|
@rcostalenz Ok then |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Introduces a new feature to inject CSS classes into the component.
What is the current behavior? (You can also link to an open issue here)
The dev has to use the current class names to change the style.
What is the new behavior (if this is a feature change)?
Dev can use existing classes.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No new changes are necessary to current users.
Other information: