-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Using global private environment to save secrets[INS-4715] #8233
Conversation
a546711
to
f8cb14d
Compare
b453cd8
to
bfb3d55
Compare
9b384d8
to
3f66590
Compare
35c9a6b
to
8367496
Compare
packages/insomnia-smoke-test/fixtures/vault-environment.yaml
Dismissed
Show dismissed
Hide dismissed
5ed3dbd
to
241dbc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments and tend to move forward as there're several rounds review before, but ideally we might still have more tests in the next as it is a relatively huge change.
@@ -51,6 +51,8 @@ export const WorkspaceEnvironmentsEditModal = ({ onClose }: { | |||
} | |||
return false; | |||
}, [selectedEnvironment]); | |||
// Do not allowed to switch to json environment if contains secret item | |||
const allowSwitchEnvironment = !selectedEnvironment?.kvPairData?.some(d => d.type === EnvironmentKvPairDataType.SECRET); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Probably need to to auto switch to kv mode for one user has been in the json mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I will add in a separate PR and add a test to cover this
b4430ab
to
c240e19
Compare
2.secret key-value pair ui
2.Add basic integration with AWS 3.Add vault secret cache and config UI
2.add a hook to get user plan
2.AWS secret nunjuckt tag config UI
…lobal environment 2.mask all secret items value when export
2.Modify rendering logic to expose decrypted secrets to script
c240e19
to
c05a95d
Compare
Changes
Leverage global private environment to add built-in support secret management capabilities.
Add a new secret type environment key-value pair to store secret variables with the following features:
We also introduce a new term Vault Key.

Vault key is used to encrypt/decrypt secret environment variables, it is not synced to the cloud, so users need to save the key themselves.
User could reset the vault key, but this will remove local secret environments in all devices.
Add a new UI in Preferences page for management:
Vault secrets can be used in scripts if user set Enable vault in scripts in settings. (Only allow to get vault secret value, set/unset/clear methods are not allowd)
The pattern is
Tasks