fix: Manage Cookie Modal [INS-5007] #8385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/insomnia/src/ui/components/modals/cookies-modal.tsx
Dismissed
Show dismissed
Hide dismissed
pavkout
force-pushed
the
feature/ins-5007
branch
from
b8a6836 to
8b39efa
Compare
cwangsmv
pushed a commit
that referenced
this pull request
Feb 24, 2025
* refactor: remove CookieList component * refactor: remove unused defaultPerPage export from Invite modal * refactor: remove unused styles for CookieList component * refactor: clean up unused code in the cookie modal * refactor: update CookiesModal props for better state management * refactor: update CookiesModal props for improved state handling * refactor: streamline state management in CookiesModal component * refactor: update cookie editor test selectors for improved stability * refactor: fix cookie editor test selector for accurate interaction * refactor: update cookie editor test to use getByText for improved selector accuracy * refactor: enhance cookie editor test to assert visibility of cookie entries * refactor: update cookie editor test to assert visibility of specific cookie entries * refactor: remove isOpen prop from CookiesModal for simplified usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following updates to the Invite modal:
Closes INS-5007, 4967