Skip to content

Updated spc700.asm to work with current bass #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anaanook
Copy link

@anaanook anaanook commented Nov 24, 2021

referenced here:
#6

I took a crack fixing it, it seems to compile OK and gives (I think) the same results as the compiled asm in spc700.h

I don't know if you want PR on this kind of stuff.. but I thought I'd give it a shot.

My workaround for the alignment isn't pretty, but it seems to get the job done. Feedback welcome, I'm new at this.

@KungFuFurby
Copy link
Owner

KungFuFurby commented Nov 25, 2021

That's actually not a bad idea to update the code for the latest version of bass. I'll use this as a test case since perhaps I can do some C++ programming to restore the align command...

The build is almost identical, but there's a wrong subroutine pointer at $04AA ($06AA in ARAM). setInstrument is at fault, meaning something went wrong on handling the sublabel conversions, probably because there's two of them and it relies on a sublabel for one of them.

@anaanook
Copy link
Author

anaanook commented Nov 25, 2021

Ahh, good catch! I didn't notice that there were duplicate named setInstrument labels, should be easy enough to fix by renaming one.

Fixed commented org line, swapped for current command

Fixed duplicate label issue
@anaanook
Copy link
Author

anaanook commented Nov 25, 2021

Yeah, upon inspection it got confused because there was a scoped label that was conflicting with the global label of the same name. I got it sorted and its producing an identical binary now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants