Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add search spinner while waiting for search to run #2567

Merged
merged 2 commits into from
Oct 2, 2020
Merged

add search spinner while waiting for search to run #2567

merged 2 commits into from
Oct 2, 2020

Conversation

peetucket
Copy link
Contributor

@peetucket peetucket commented Sep 30, 2020 •
edited
Loading

Why was this change made?

Addresses part of #2182 (search spinner)
Timeouts are in #2583

  • adds search spinner when searches are executing (sinopia or QA)
  • clears any current search results as soon as a new search is started (and shows the spinner when running the new search of course)

This is how the loading spinner looks: (Note: the "results loading" text is in a span that only shows for screen readers.)

spinner

How was this change tested?

  • Localhost browser

Which documentation and/or configurations were updated?

None

@peetucket peetucket force-pushed the 2182-search-spinner branch 10 times, most recently from 19ae87e to 3a886aa Compare October 2, 2020 17:57
@peetucket peetucket mentioned this pull request Oct 2, 2020
Closed
@peetucket peetucket force-pushed the 2182-search-spinner branch from 3a886aa to c635f1b Compare October 2, 2020 18:40
@peetucket peetucket marked this pull request as ready for review October 2, 2020 18:41
jermnelson
jermnelson requested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a feature test.

@peetucket
Copy link
Contributor Author

Updated a search feature test to look for the spinner

@peetucket peetucket force-pushed the 2182-search-spinner branch from 76a9999 to 68f7e57 Compare October 2, 2020 21:51
@peetucket peetucket force-pushed the 2182-search-spinner branch from 68f7e57 to 320a888 Compare October 2, 2020 21:54
@jermnelson jermnelson merged commit 3339561 into master Oct 2, 2020
@jermnelson jermnelson deleted the 2182-search-spinner branch October 2, 2020 22:04
@peetucket peetucket mentioned this pull request Oct 2, 2020
Closed
@jgreben jgreben mentioned this pull request Oct 6, 2020
Closed
@sfolsom sfolsom mentioned this pull request Oct 23, 2020
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jermnelson jermnelson jermnelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peetucket @jermnelson