Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw warning for changing val_loss #2868

Closed
edenlightning opened this issue Aug 7, 2020 · 2 comments · Fixed by #3014
Closed

Throw warning for changing val_loss #2868

edenlightning opened this issue Aug 7, 2020 · 2 comments · Fixed by #3014
Assignees
@shivin7
Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on let's do it! approved to implement

Comments

@edenlightning
Copy link
Contributor

Add warning to user that when changing val_loss to another keyword it will break checkpointing, early stopping, and other features relying on it.
@edenlightning edenlightning added bug Something isn't working help wanted Open to be worked on good first issue Good for newcomers let's do it! approved to implement allowed_pre_1.0 labels Aug 7, 2020
@shivin7
Copy link

shivin7 commented Aug 11, 2020

Hi @Borda, newcomer here. Can I work on this?

@Borda
Copy link
Member

Borda commented Aug 11, 2020

@shivin7 perfect, go ahead! 🎉

@shivin7 shivin7 mentioned this issue Aug 16, 2020
Closed
7 tasks
@williamFalcon williamFalcon mentioned this issue Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivin7 shivin7

Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on let's do it! approved to implement
Projects
None yet
Milestone
No milestone
3 participants
@Borda @shivin7 @edenlightning