Throw warning on changing val_loss #3010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @shivin7! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-16 23:38:34 UTC |
|
Right now I'm throwing the same warning when the output of |
Codecov Report
@@ Coverage Diff @@
## master #3010 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 81 81
Lines 7644 7645 +1
======================================
- Hits 6878 6858 -20
- Misses 766 787 +21 |
| @@ -343,6 +343,11 @@ def _evaluate( | |||
| m = 'only EvalResults or dicts are allowed from validation_step' | |||
| raise MisconfigurationException(m) | |||
|
|
|||
| # throw warning if key other than 'val_loss' is used in output | |||
| if not isinstance(output, EvalResult) or 'val_loss' not in output.keys(): | |||
There was a problem hiding this comment.
that’s not what we meant.
the warning js when the word monitor changes in a callback AND you are using a result obj
There was a problem hiding this comment.
Oh I see.
So something like when EarlyStopping(monitor='not_val_loss') AND using a Result object?
|
this is time sensitive since we need to get the release out today. I'll take care of this one, but please give another issue a shot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2868
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
Please note : I'm a little new with the tests so any comments are really helpful. Thanks!