Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pytorch Lightning as a conda package #794

Closed
dangpzanco opened this issue Feb 6, 2020 · 10 comments
Closed

Release Pytorch Lightning as a conda package #794

dangpzanco opened this issue Feb 6, 2020 · 10 comments
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Milestone

Comments

@dangpzanco
Copy link

🚀 Feature

Please make the pytorch-lightning package available from the conda package manager. This would probably be done through conda-forge: conda install pytorch-lightning -c conda-forge

Motivation

The default way of installing Pytorch is via their conda channel, so (probably) most users of Lightning already use the conda package manager.

Conda packages provide automatic updates (conda update --all) and better package dependencies management, which could make the user's life a lot easier.

Pitch

I'd like to install pytorch-lightning and its dependencies via this command:

conda install pytorch-lightning -c conda-forge

Ideally, this wouldn't force reinstall the pytorch package from its channel to conda-forge.

Alternatives

My personal way of installing pytorch-lightning is running:
pip install --no-deps pytorch-lightning test-tube
And then conda install the missing dependencies that show up on pip check.

On version 0.5.3.x this was mandatory, since the required pytorch-lightning packages would mess up numpy and other conda packages.

@dangpzanco dangpzanco added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 6, 2020
@williamFalcon
Copy link
Contributor

@dangpzanco agreed. Is this something you can take care of? at least the config. then we can set up what needs to happen for conda release.

@dangpzanco
Copy link
Author

@williamFalcon I'm not sure if I'll be able to take care of this (I don't have much spare time). But if nothing comes up in a couple of weeks, I'll probably look into it.

@williamFalcon
Copy link
Contributor

@Borda want to look at this for this release?

@williamFalcon williamFalcon added this to the 0.6.1 milestone Feb 11, 2020
@Borda
Copy link
Member

Borda commented Feb 11, 2020

Depends how much time will leave, I don't have any experience with conda packaging yet...

@Borda Borda modified the milestones: 0.6.1, 0.6.2 Feb 25, 2020
@awaelchli
Copy link
Contributor

According to @hadim it is not possible to release as conda package:
#199 (comment)

@Borda Borda modified the milestones: 0.7.2, 0.7.3 Apr 3, 2020
@Borda Borda modified the milestones: 0.7.4, 0.7.5 Apr 24, 2020
@Borda Borda closed this as completed May 12, 2020
@hadim
Copy link
Contributor

hadim commented May 30, 2020

Apparently it's possible to add pytorch packages to conda-forge following this example: conda-forge/staged-recipes#11762

The pytorch version available on conda-forge is 1.1 CPU so tests won't pass but tests are already performed on this repo anyway.

@hadim
Copy link
Contributor

hadim commented May 30, 2020

See conda-forge/staged-recipes#11778

@awaelchli
Copy link
Contributor

would be great to have it in conda! Thanks hadim

@awaelchli awaelchli reopened this May 30, 2020
@hadim
Copy link
Contributor

hadim commented Jun 3, 2020

You can close here.

@Borda Borda closed this as completed Jun 3, 2020
@awaelchli
Copy link
Contributor

we should probably add instructions in the readme.
And it does not seem to work on windows but that could be because... Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

5 participants