Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme with conda installation instruction #2099

Merged
merged 4 commits into from
Jun 8, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 7, 2020

What does this PR do?

follow up on #794

@awaelchli awaelchli added the docs Documentation related label Jun 7, 2020
@mergify mergify bot requested a review from a team June 7, 2020 02:25
@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #2099 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2099   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files          75      75           
  Lines        4710    4710           
======================================
  Hits         4067    4067           
  Misses        643     643           

@Borda Borda added the ready PRs ready to be merged label Jun 7, 2020
@mergify mergify bot requested a review from a team June 7, 2020 09:25
@Borda
Copy link
Member

Borda commented Jun 7, 2020

well, it not very clear to me how we can push new versions, for pip we have a workflow that builds particular release and pushes to PyPI, but how about condo... @hadim mind bring some light?

@hadim
Copy link
Contributor

hadim commented Jun 7, 2020

You can either submit a PR to the feedstock manually. You could also submit this PR using PL CI system at each release.

And the last option (probably the best): at each new pypi release, conda-forge bot will detect it, submit a PR to the PL feedstock and ping you to review it. Then you can just merge if everything is green. Or you can also commit to the PR to add/delete/edit any deps or other things.

@awaelchli
Copy link
Contributor Author

@hadim how do we register it with the conda-forge bot?

@hadim
Copy link
Contributor

hadim commented Jun 7, 2020

@awaelchli to get pinged you mean?

The bot already scans all the conda-forge packages for new pypi releases, you have nothing to do. If you want to get notified you need the be added as a maintainer or you can just subscribe to the feedstock repository as for all GH repo: https://github.com/conda-forge/pytorch-lightning-feedstock

@hadim
Copy link
Contributor

hadim commented Jun 7, 2020

Here is an example of automatically created PR for another package: conda-forge/blessed-feedstock#4

@awaelchli
Copy link
Contributor Author

great, was not sure if it's already automatic or not.
then all is fine with me, thanks hadim :)

@Borda
Copy link
Member

Borda commented Jun 7, 2020

@hadim Thank you!
btw how could we add Description section?
https://anaconda.org/conda-forge/pytorch-lightning

@hadim
Copy link
Contributor

hadim commented Jun 7, 2020

You can't. All of this is automatic but I don't think a lot of people install packages from this page anyway. If it's really important for you then you would have to contact conda-forge devs.

@williamFalcon williamFalcon merged commit 1f95fb9 into master Jun 8, 2020
@Borda Borda deleted the docs/readme-conda branch June 8, 2020 12:31
justusschock pushed a commit that referenced this pull request Jun 29, 2020
* update readme with conda installation instruction

* fix team header

* bibtex spelling

* Update README.md

Co-authored-by: William Falcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants