-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme with conda installation instruction #2099
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2099 +/- ##
======================================
Coverage 86% 86%
======================================
Files 75 75
Lines 4710 4710
======================================
Hits 4067 4067
Misses 643 643 |
well, it not very clear to me how we can push new versions, for pip we have a workflow that builds particular release and pushes to PyPI, but how about condo... @hadim mind bring some light? |
You can either submit a PR to the feedstock manually. You could also submit this PR using PL CI system at each release. And the last option (probably the best): at each new pypi release, conda-forge bot will detect it, submit a PR to the PL feedstock and ping you to review it. Then you can just merge if everything is green. Or you can also commit to the PR to add/delete/edit any deps or other things. |
@hadim how do we register it with the conda-forge bot? |
@awaelchli to get pinged you mean? The bot already scans all the conda-forge packages for new pypi releases, you have nothing to do. If you want to get notified you need the be added as a maintainer or you can just subscribe to the feedstock repository as for all GH repo: https://github.com/conda-forge/pytorch-lightning-feedstock |
Here is an example of automatically created PR for another package: conda-forge/blessed-feedstock#4 |
great, was not sure if it's already automatic or not. |
@hadim Thank you! |
You can't. All of this is automatic but I don't think a lot of people install packages from this page anyway. If it's really important for you then you would have to contact conda-forge devs. |
* update readme with conda installation instruction * fix team header * bibtex spelling * Update README.md Co-authored-by: William Falcon <[email protected]>
What does this PR do?
follow up on #794