Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies are required for deprecated logging module #798

Closed
tullie opened this issue Feb 7, 2020 · 3 comments · Fixed by #799 or #900
Closed

Optional dependencies are required for deprecated logging module #798

tullie opened this issue Feb 7, 2020 · 3 comments · Fixed by #799 or #900
Assignees
Labels
bug Something isn't working good first issue Good for newcomers logger Related to the Loggers
Milestone

Comments

@tullie
Copy link
Contributor

tullie commented Feb 7, 2020

🐛 Bug

There is a backwards compatibility issues coming from PR #767. Notably, if a user doesn't have any of the extra logging dependencies then they'll be an import error.

To Reproduce

  1. Remove all logging dependencies from your environment (E.g. comet)
  2. Depend on the deprecated pytorch_lightning.logging package and run

Expected behavior

We expect to maintain backwards compatibility here so optional dependencies shouldn't be required.

@tullie tullie added the bug Something isn't working label Feb 7, 2020
@Borda
Copy link
Member

Borda commented Feb 7, 2020

Not sure if I understand correctly so if you remove eg mlflow and import pytorch_lightning.logging it crashes with an import error?
@tullie how is it related to issue 155 linked in bug title?

@tullie
Copy link
Contributor Author

tullie commented Feb 10, 2020

Sorry it isn't related to 155. Not sure how that slipped in there.

Otherwise, your understanding is right.

@Borda
Copy link
Member

Borda commented Feb 11, 2020

Sorry it isn't related to 155. Not sure how that slipped in there.

The tricky thing is when it creates issue/PR it enters the text field starting with # which is associated with an issue/PR number so it automatically opens suggestion pop-up and the oldest issue (on the top) is the 155 and without enough attention, it is placed there automatically... It happened me several times already :]
@williamFalcon could you grant to @PyTorchLightning/core-contributors right to edit issues/PR so we do not border users with simple-straight-forward issues... 8-]

@williamFalcon williamFalcon added this to the 0.6.1 milestone Feb 11, 2020
@Borda Borda added the good first issue Good for newcomers label Feb 18, 2020
@Borda Borda added the logger Related to the Loggers label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers logger Related to the Loggers
Projects
None yet
3 participants