Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards compatibility for deprecated logging module #799

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

tullie
Copy link
Contributor

@tullie tullie commented Feb 7, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #798

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@tullie tullie requested a review from Borda February 7, 2020 19:09
@Borda
Copy link
Member

Borda commented Feb 7, 2020

Maybe we do not have open an issue if have already fix... And rather write the description here instead... So there is no no need to swapping between issue and PR =)

@Borda
Copy link
Member

Borda commented Feb 7, 2020

it seems that it does fix one hole but breaks other compatibility...

import pytorch_lightning.loggers.mlflow
import pytorch_lightning.logging.mlflow
Traceback (most recent call last):
  File "/home/jb/.local/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 3265, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-10-8c3cb4802809>", line 1, in <module>
    import pytorch_lightning.logging.mlflow
  File "/home/jb//pydev/_pydev_bundle/pydev_import_hook.py", line 21, in do_import
    module = self._system_import(name, *args, **kwargs)
ModuleNotFoundError: No module named 'pytorch_lightning.logging.mlflow'

@tullie
Copy link
Contributor Author

tullie commented Feb 10, 2020

Yeah agreed that making the issues doesn't make sense. I only did it because the PR description prompted me too.

Good point. I'll revise today to fix that too.

@Borda Borda added the bug Something isn't working label Feb 10, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 10, 2020
@williamFalcon williamFalcon merged commit 6443d15 into Lightning-AI:master Feb 11, 2020
@Borda
Copy link
Member

Borda commented Feb 11, 2020

@williamFalcon it was not fixed... @tullie wanted to continue on this...

@williamFalcon
Copy link
Contributor

@Borda oh shoot, sorry didn't read that last comment. Let's finish this in a separate PR?

@Borda
Copy link
Member

Borda commented Feb 11, 2020

Well as you already merged it, it has to done in other PR #815?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional dependencies are required for deprecated logging module
3 participants