Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signature of LightningModule.training_step_end #10094

Merged
merged 4 commits into from
Nov 3, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 23, 2021

What does this PR do?

Addresses #6404 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added design Includes a design discussion docs Documentation related refactor labels Oct 23, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 23, 2021
@awaelchli awaelchli marked this pull request as ready for review October 24, 2021 20:54
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #10094 (79a918a) into master (3a4e997) will increase coverage by 4%.
The diff coverage is 100%.

❗ Current head 79a918a differs from pull request most recent head 086f918. Consider uploading reports for the commit 086f918 to get more accurate results

@@           Coverage Diff            @@
##           master   #10094    +/-   ##
========================================
+ Coverage      89%      92%    +4%     
========================================
  Files         180      182     +2     
  Lines       16146    16157    +11     
========================================
+ Hits        14317    14942   +625     
+ Misses       1829     1215   -614     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 29, 2021
@awaelchli awaelchli enabled auto-merge (squash) November 1, 2021 09:53
@tchaton tchaton modified the milestones: v1.5, v1.6 Nov 1, 2021
@awaelchli awaelchli merged commit b3db1b6 into master Nov 3, 2021
@awaelchli awaelchli deleted the bugfix/step-end-signature branch November 3, 2021 13:38
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion docs Documentation related ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants