Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs iterable datasets #1281

Merged

Conversation

djbyrne
Copy link
Contributor

@djbyrne djbyrne commented Mar 29, 2020

Docs Update:

Sequntial Data section now contains info on using IterableDatasets

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Donal Byrne added 2 commits March 29, 2020 13:38
* Sequntial Data section now contains info on using IterableDatasets
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! - just a minor comment

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #1281 into master will not change coverage by %.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1281   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          61      61           
  Lines        3153    3153           
======================================
  Hits         2886    2886           
  Misses        267     267           

@williamFalcon williamFalcon merged commit fb42872 into Lightning-AI:master Mar 29, 2020
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Mar 30, 2020
* Updated Sequencial Data docs

* Sequntial Data section now contains info on using IterableDatasets

* * Undid reformatting of bullet points

* * added information about val_check_interval

Co-authored-by: Donal Byrne <[email protected]>
@Borda Borda added the docs Documentation related label Mar 30, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 30, 2020
@mergify mergify bot requested a review from a team March 30, 2020 23:16
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 3, 2020
* Updated Sequencial Data docs

* Sequntial Data section now contains info on using IterableDatasets

* * Undid reformatting of bullet points

* * added information about val_check_interval

Co-authored-by: Donal Byrne <[email protected]>
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants