Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes #1362

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Doc fixes #1362

merged 3 commits into from
Apr 3, 2020

Conversation

jbschiratti
Copy link
Contributor

What does this PR do?

Doc fixes not addressed in #1357.

PR review

Anyone in the community is free to review the PR once the tests have passed 👍

@mergify mergify bot requested a review from a team April 3, 2020 14:14
@jbschiratti
Copy link
Contributor Author

jbschiratti commented Apr 3, 2020

@awaelchli @Borda this should allow to fix the docstrings !

Since this is only doc, feel free to merge if it is OK with you (no need to wait for the CI, right?)

@Borda Borda added the docs Documentation related label Apr 3, 2020
@Borda Borda added this to the 0.7.2 milestone Apr 3, 2020
@Borda Borda added the ready PRs ready to be merged label Apr 3, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda requested review from williamFalcon, ethanwharris, jeremyjordan and a team April 3, 2020 14:20
@awaelchli
Copy link
Contributor

Thanks a lot @jbschiratti !

@williamFalcon williamFalcon merged commit e570d2e into Lightning-AI:master Apr 3, 2020
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 4, 2020
* Doc fixes from Lightning-AI#1357 (awaelchli's comments) + changelog.

* Fix indentation.

* Add blank line to fix doc build?
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
* Doc fixes from Lightning-AI#1357 (awaelchli's comments) + changelog.

* Fix indentation.

* Add blank line to fix doc build?
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants