Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip workers warning test on windows #1533

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Skip workers warning test on windows #1533

merged 1 commit into from
Apr 20, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 20, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Extends #1430.
On Windows, the test test_warning_with_few_workers fails because it expects a warning, but the warning is omitted here when on Windows, so the test should be skipped in that case.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 20, 2020 03:21
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #1533 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1533   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          68      68           
  Lines        3804    3804           
======================================
  Hits         3441    3441           
  Misses        363     363           

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐰

@Borda Borda added feature Is an improvement or enhancement ci Continuous Integration labels Apr 20, 2020
@mergify mergify bot requested a review from a team April 20, 2020 06:28
@mergify mergify bot requested a review from a team April 20, 2020 07:55
@mergify mergify bot merged commit 452fa85 into Lightning-AI:master Apr 20, 2020
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2020

Great job! =)

@awaelchli awaelchli deleted the bugfix/workers-windows-warning branch April 24, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants