added warning for None dataloader #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ybrovman! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-06 15:17:45 UTC |
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 69 69
Lines 4156 4161 +5
======================================
+ Hits 3666 3670 +4
- Misses 490 491 +1 |
jeremyjordan
reviewed
May 6, 2020
| raise MisconfigurationException( | ||
| f'Your {mode}_dataloader has shuffle=True, it is best practice to turn' | ||
| ' this off for validation and test dataloaders.') | ||
| dataloadersClean.append(loader) |
There was a problem hiding this comment.
this should be dataloaders_clean, i'm surprised our pep8speaks bot didn't mention this
https://www.python.org/dev/peps/pep-0008/#function-and-variable-names
Borda
requested changes
May 6, 2020
| f'Your {mode}_dataloader has shuffle=True, it is best practice to turn' | ||
| ' this off for validation and test dataloaders.') | ||
| dataloaders_clean.append(loader) | ||
| else: |
There was a problem hiding this comment.
I would keep the previous logic and here add simply:
if any([dl is None for dl in dataloaders]):
rank_zero_warn("One of given dataloaders is None and it will be skipped.")
There was a problem hiding this comment.
ok sure, makes sense
added 2 commits
May 6, 2020 11:16
Borda
approved these changes
May 6, 2020
jeremyjordan
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
This is follow up PR from PR #1560. Logs a warning if there are any validation dataloaders that are None.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃