Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen ddp support #1961

Merged
merged 4 commits into from
May 26, 2020
Merged

Gen ddp support #1961

merged 4 commits into from
May 26, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented May 26, 2020

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify
Copy link
Contributor

mergify bot commented May 26, 2020

This pull request is now in conflict... :(

@mergify mergify bot requested a review from a team May 26, 2020 17:27
@williamFalcon williamFalcon changed the title Gen ddp Gen ddp support May 26, 2020
@Borda Borda added the feature Is an improvement or enhancement label May 26, 2020
@Borda Borda added this to the 0.8.0 milestone May 26, 2020
@mergify mergify bot requested a review from a team May 26, 2020 17:40
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #1961 into master will not change coverage.
The diff coverage is 50%.

@@          Coverage Diff           @@
##           master   #1961   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          74      74           
  Lines        4650    4650           
======================================
  Hits         4070    4070           
  Misses        580     580           

@williamFalcon williamFalcon merged commit 460ab54 into master May 26, 2020
@Borda Borda deleted the gen_ddp branch May 27, 2020 07:57
justusschock pushed a commit that referenced this pull request Jun 29, 2020
* updated docs

* added mixed

* added mixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants