Added some more potentially robust ways to do learning rate tuning #19867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed in #1767, the learning rate tuner suggests the minimum gradient of the loss via
torch.argmin(torch.gradient(losses)[0])
. This makes it a little sensitive to a noisy loss vs LR landscape. I added a few methods discussed here, and found they worked pretty well for my use cases (see example below, where gradient-based estimation picks out a very low LR).Defaults are set so no breaking changes are introduced.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19867.org.readthedocs.build/en/19867/