Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading exception raised during batch scaling #2223

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Misleading exception raised during batch scaling #2223

merged 3 commits into from
Jul 29, 2020

Conversation

tejasvi
Copy link
Contributor

@tejasvi tejasvi commented Jun 17, 2020

Resuming #1973, after the unintended premature merge.

@pep8speaks
Copy link

pep8speaks commented Jun 17, 2020 •
edited
Loading

Hello @tejasvi! Thanks for updating this PR.

Line 256:58: W291 trailing whitespace

Comment last updated at 2020-07-01 11:52:06 UTC

@mergify mergify bot requested a review from a team June 17, 2020 15:05
Borda
Borda requested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see comments fro the previous PR #1973

@mergify mergify bot requested a review from a team June 17, 2020 15:23
tejasvi and others added 3 commits July 1, 2020 13:51
@tejasvi @Borda
Misleading exception raised during batch scaling
4378257 
Use batch_size from `model.hparams.batch_size` instead of `model.batch_size`
@tejasvi @Borda
Improvements considering #1896
179f6a5
@tejasvi @Borda
Apply suggestions from code review
3d79243 
Co-authored-by: Jirka Borovec <[email protected]>
@SkafteNicki SkafteNicki mentioned this pull request Jul 2, 2020
Closed
5 tasks
@Borda Borda added bug Something isn't working ready PRs ready to be merged labels Jul 15, 2020
@mergify mergify bot requested a review from a team July 15, 2020 13:33
@Borda Borda requested review from awaelchli, ethanwharris, justusschock and neggert and removed request for a team July 15, 2020 13:33
@mergify mergify bot requested a review from a team July 15, 2020 13:33
@Borda Borda mentioned this pull request Jul 15, 2020
Closed
ethanwharris
ethanwharris approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team July 27, 2020 20:56
thschaaf
thschaaf approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@thschaaf thschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamFalcon williamFalcon merged commit 8ab5bcd into Lightning-AI:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@thschaaf thschaaf thschaaf approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@neggert neggert Awaiting requested review from neggert

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tejasvi @pep8speaks @Borda @ethanwharris @thschaaf @williamFalcon