Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug misstep #2475

Closed
wants to merge 27 commits into from
Closed

Debug misstep #2475

wants to merge 27 commits into from

Conversation

ameliatqy
Copy link

@ameliatqy ameliatqy commented Jul 2, 2020

What does this PR do?

Fixes # 2455 [This is a Draft PR]

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Yes, I am new to contributing to open-source and actually find it quite fun. May be time to consider a new hobby...

@Borda Borda requested a review from awaelchli July 2, 2020 23:34
@ameliatqy ameliatqy mentioned this pull request Jul 3, 2020
7 tasks
@ameliatqy
Copy link
Author

I messed on this pull request when trying to rebase. To be safe, I started a new one - please see new pull request #2478

@ameliatqy ameliatqy closed this Jul 3, 2020
@Borda
Copy link
Member

Borda commented Jul 3, 2020

I messed on this pull request when trying to rebase. To be safe, I started a new one - please see new pull request #2478

you can just ping us and we can help you to fix it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants