-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid zeros in dice and iou #2567
Conversation
it really should be an epsilon... but in 16 bit 1e-15 is 0.... @Borda |
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
======================================
Coverage 91% 91%
======================================
Files 70 70
Lines 5724 5753 +29
======================================
+ Hits 5215 5242 +27
- Misses 509 511 +2 |
if you test that denom is not zero then you do not need any eps EDIT: https://stackoverflow.com/a/9528486/4521646
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-09 22:45:24 UTC |
What does this PR do?
Fixes #2545 better way that adding epsilon
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃