-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tensorboard version #3132
fix tensorboard version #3132
Conversation
just thinking, all tests are passing... what was the failing case? |
Codecov Report
@@ Coverage Diff @@
## master #3132 +/- ##
=======================================
- Coverage 90% 85% -5%
=======================================
Files 104 98 -6
Lines 8126 8073 -53
=======================================
- Hits 7314 6898 -416
- Misses 812 1175 +363 |
6061dfa
to
222d247
Compare
This pull request is now in conflict... :( |
222d247
to
8a79d15
Compare
this seems quite unrelated...
|
f1a199a
to
42ec067
Compare
96fb235
to
cf4c5eb
Compare
b63bfe8
to
cd25fb5
Compare
this is a funny dependency, PT made it as optional as we do... so we cannot drop it :( |
This pull request is now in conflict... :( |
266d3d2
to
f5c48c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is now in conflict... :( |
f5c48c8
to
c9b05ca
Compare
seems only Horovod id failing, unrelated to this PR
|
What does this PR do?
Fixes #3011
Fixes #3033
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃