Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush experiment in tensorboard logger on finalize #3920

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Oct 6, 2020

What does this PR do?

#2126 removed flush from save() as it was excessive in tensorboard
Here we flush in finalize to gather metrics that may not have been flushed during the async writing in order to give us better coverage

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team October 6, 2020 23:24
@edenlightning edenlightning added this to the 0.10.0 milestone Oct 6, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #3920 into master will increase coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3920    +/-   ##
=======================================
+ Coverage      82%     86%    +5%     
=======================================
  Files         113     113            
  Lines        8479    8520    +41     
=======================================
+ Hits         6929    7355   +426     
+ Misses       1550    1165   -385     

@williamFalcon williamFalcon merged commit 6c47535 into Lightning-AI:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants