speed-up testing #504
speed-up testing #504
Conversation
|
@Borda can we spend some time working on making the tests faster? maybe use a smaller dataset or something? |
that would be perfect, (that is why I made this as WIP) since some contributors are creating PR with their first commit instead of developing in own branch and make PR when it is ready... the problem is that such approach takes almost all your CI workers so than all other PRs have to queue for hours... Yes, in general the test should be as simple and straight forward as possible, so for example we can do:
|
|
For the queuing problem: An alternative solution I've seen for bigger opensource projects would be to have a trigger for testing through a github bot. This way we don't run on every commit.
|
# Conflicts: # pytorch_lightning/testing/__init__.py # pytorch_lightning/testing/lm_test_module.py # pytorch_lightning/testing/lm_test_module_base.py # pytorch_lightning/testing/lm_test_module_mixins.py # pytorch_lightning/testing/model.py # pytorch_lightning/testing/model_base.py # pytorch_lightning/testing/model_mixins.py # pytorch_lightning/testing/test_module.py # pytorch_lightning/testing/test_module_base.py # pytorch_lightning/testing/test_module_mixins.py
|
@williamFalcon @jeffling @neggert @Ir1d test time 20min -> 10min |
Co-Authored-By: Ir1dXD <[email protected]>
This reverts commit b86aee9
|
@Borda great job! |
I have introduced a smaller test dataset which is only 2k samples from MNIST dataset which lower the testing time from about 20min just to 10min 😈
I have also refactored imports in the test section