Abstract Mixin classes #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! I don’t love that we need to define all of those abstract methods. It makes everything interlinked (a pre-existing problem which this PR reveals), which defeats one of the main reasons to use mixins. That can be a task for a future PR, though. |
|
Very nice. Re: @neggert's point, I think we should see if we can build the callback/plugin system and then switch these mixins to use them so it can solve the interconnectedness problem that was highlighted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a proposal how to make the Mixin classes "safer" - as abstract classes they should not be created and also with listed attributes in virtual init it is easier to check what attributes are needed/used...
https://softwareengineering.stackexchange.com/a/355476/337564
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.