Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logging error #575

Merged
merged 3 commits into from
Dec 4, 2019
Merged

fix logging error #575

merged 3 commits into from
Dec 4, 2019

Conversation

wakandan
Copy link
Contributor

@wakandan wakandan commented Dec 3, 2019 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #574

Borda
Borda requested changes Dec 3, 2019
View reviewed changes
Borda
Borda approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch =)

Ir1d
Ir1d approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@Ir1d Ir1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx~

@williamFalcon williamFalcon merged commit b5b77e4 into Lightning-AI:master Dec 4, 2019
@williamFalcon
Copy link
Contributor

@wakandan good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@Ir1d Ir1d Ir1d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in logging call pt_callbacks.py
4 participants
@wakandan @williamFalcon @Borda @Ir1d