Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some codefactor issues #756

Merged
merged 31 commits into from
Feb 1, 2020
Merged

Resolve some codefactor issues #756

merged 31 commits into from
Feb 1, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jan 27, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes issues that codefactor is complaining about. See all issues here.
I only looked at the easy ones and did not touch anything complex.
If you are not happy with some of the changes, let me know and I will revert these.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli
Copy link
Contributor Author

GPU tests also pass, except amp which I don't have and ddp2 which needs SLURM and I don't have that.

@awaelchli awaelchli marked this pull request as ready for review January 27, 2020 08:50
@awaelchli awaelchli requested a review from Borda January 27, 2020 08:50
Borda
Borda approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice formatting cleaning :]

tests/test_restore_models.py Outdated
@@ -58,9 +58,9 @@ def test_running_test_pretrained_model_ddp(tmpdir):


def test_running_test_pretrained_model(tmpdir):
"""Verify test() on pretrained model"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the docs, a sentence should end with "."

@Borda Borda added feature Is an improvement or enhancement good first issue Good for newcomers labels Jan 27, 2020
@Borda
Copy link
Member

Borda commented Jan 31, 2020

@awaelchli could you pls rebase master...

@Borda Borda added the ready PRs ready to be merged label Jan 31, 2020
@Borda Borda added this to the 0.6.1 milestone Jan 31, 2020
Adrian Wälchli added 4 commits January 31, 2020 23:42
@Borda
Copy link
Member

Borda commented Jan 31, 2020

@awaelchli btw, you may check also the codacy issues in another PR...
https://app.codacy.com/manual/Borda/pytorch-lightning/dashboard

@awaelchli
Copy link
Contributor Author

yes I may take a look at these later.
Also, do you know if it is possible to see codefactor/codacy results on a pull request to see if they are resolved?

@Borda
Copy link
Member

Borda commented Feb 1, 2020

I d love to see it too... I have asked @williamFalcon for adding codefactor here, creating PTL account because actually there is just my fork...

@williamFalcon
Copy link
Contributor

@awaelchli rebase?

kuynzereb and others added 6 commits February 1, 2020 22:09
@kuynzereb
Fix default ckpt path when logger exists (#771)
75ae29c
@Borda
rename logging -> loggers (#767)
0f6e94e 
* move logging >> loggers

* add warning

* fix tests

* logging alias

* formatting

* formatting
@jeremyjordan
add more detail to tbptt example (#755)
373f533 
* add more detail to tbptt example

* warn user about new arg in training_step
use isinstance for type checks
c410609
revert isinstance check back to type
265b422 
broke tests, because bool is actually subclass of int
Merge branch 'master' into codefactor
c7e9bb6
@awaelchli
Copy link
Contributor Author

@williamFalcon rebased

@Borda
Copy link
Member

Borda commented Feb 1, 2020 •
edited
Loading

@williamFalcon could you create PyTorch-Lightning account on www.codefactor.io? but it seems that it allows login with a GH account... or we may switch to www.Codacy.com which supports organisations...

@williamFalcon williamFalcon merged commit 472f394 into Lightning-AI:master Feb 1, 2020
@Borda Borda mentioned this pull request Feb 2, 2020
Merged
@awaelchli awaelchli deleted the codefactor branch March 7, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
feature Is an improvement or enhancement good first issue Good for newcomers ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@awaelchli @Borda @williamFalcon @kuynzereb @jeremyjordan