Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update badges & drop Travis/Appveyor #826

Merged
merged 3 commits into from
Feb 14, 2020
Merged

update badges & drop Travis/Appveyor #826

merged 3 commits into from
Feb 14, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 12, 2020

What does this PR do?

Followup #823 drops Travis and Appveyor...
Implementing matrix asked in #778

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@Borda
Copy link
Member Author

Borda commented Feb 12, 2020

there is an issue which was not found earlier...

        raise AttributeError("'{}' object has no attribute '{}'".format(
>           type(self).__name__, name))
E       AttributeError: 'LightningTestModel' object has no attribute '_lazy_train_dataloader'

https://github.com/PyTorchLightning/pytorch-lightning/runs/441556524?check_suite_focus=true

@Borda Borda requested a review from a team February 12, 2020 16:56
@Borda Borda added the feature Is an improvement or enhancement label Feb 12, 2020
@Borda Borda changed the title update badges & drop Travis/Appveyor [wip] update badges & drop Travis/Appveyor Feb 13, 2020
@Borda
Copy link
Member Author

Borda commented Feb 13, 2020

@williamFalcon @PyTorchLightning/core-contributors ^^

@williamFalcon williamFalcon merged commit 8f1a98d into Lightning-AI:master Feb 14, 2020
@Borda Borda deleted the update-badges branch February 14, 2020 11:54
Borda added a commit that referenced this pull request Feb 14, 2020
* drop Travis

* drop Appveyor

* update badges
hanbyul-kim pushed a commit to hanbyul-kim/pytorch-lightning that referenced this pull request Feb 16, 2020
* drop Travis

* drop Appveyor

* update badges
hanbyul-kim pushed a commit to hanbyul-kim/pytorch-lightning that referenced this pull request Feb 24, 2020
* drop Travis

* drop Appveyor

* update badges
williamFalcon added a commit that referenced this pull request Feb 27, 2020
* add more underline

* fix LightningMudule import error

* remove unneeded blank line

* escape asterisk to fix inline emphasis warning

* add PULL_REQUEST_TEMPLATE.md

* add __init__.py and import imagenet_example

* fix duplicate label

* add noindex option to fix duplicate object warnings

* remove unexpected indent

* refer explicit LightningModule

* fix minor bug

* refer EarlyStopping explicitly

* restore exclude patterns

* change the way how to refer class

* remove unused import

* update badges & drop Travis/Appveyor (#826)

* drop Travis

* drop Appveyor

* update badges

* fix missing PyPI images & CI badges (#853)

* docs - anchor links (#848)

* docs - add links

* add desc.

* add Greeting action (#843)

* add Greeting action

* Update greetings.yml

Co-authored-by: William Falcon <[email protected]>

* add pep8speaks (#842)

* advanced profiler describe + cleaned up tests (#837)

* add py36 compatibility

* add test case to capture previous bug

* clean up tests

* clean up tests

* Update lightning_module_template.py

* Update lightning.py

* respond lint issues

* break long line

* break more lines

* checkout conflicting files from master

* shorten url

* checkout from upstream/master

* remove trailing whitespaces

* remove unused import LightningModule

* fix sphinx bot warnings

* Apply suggestions from code review

just to trigger CI

* Update .github/workflows/greetings.yml

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: William Falcon <[email protected]>
Co-authored-by: Jeremy Jordan <[email protected]>
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
* add more underline

* fix LightningMudule import error

* remove unneeded blank line

* escape asterisk to fix inline emphasis warning

* add PULL_REQUEST_TEMPLATE.md

* add __init__.py and import imagenet_example

* fix duplicate label

* add noindex option to fix duplicate object warnings

* remove unexpected indent

* refer explicit LightningModule

* fix minor bug

* refer EarlyStopping explicitly

* restore exclude patterns

* change the way how to refer class

* remove unused import

* update badges & drop Travis/Appveyor (Lightning-AI#826)

* drop Travis

* drop Appveyor

* update badges

* fix missing PyPI images & CI badges (Lightning-AI#853)

* docs - anchor links (Lightning-AI#848)

* docs - add links

* add desc.

* add Greeting action (Lightning-AI#843)

* add Greeting action

* Update greetings.yml

Co-authored-by: William Falcon <[email protected]>

* add pep8speaks (Lightning-AI#842)

* advanced profiler describe + cleaned up tests (Lightning-AI#837)

* add py36 compatibility

* add test case to capture previous bug

* clean up tests

* clean up tests

* Update lightning_module_template.py

* Update lightning.py

* respond lint issues

* break long line

* break more lines

* checkout conflicting files from master

* shorten url

* checkout from upstream/master

* remove trailing whitespaces

* remove unused import LightningModule

* fix sphinx bot warnings

* Apply suggestions from code review

just to trigger CI

* Update .github/workflows/greetings.yml

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: William Falcon <[email protected]>
Co-authored-by: Jeremy Jordan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants