Relax hparams in model loading #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relax model loading hparams test wip wip fix warning finish test remove unused import
|
@awaelchli can we enable support for just passing in a dictionary instead of a namespace? (in a new issue / PR) |
ethanwharris
approved these changes
Feb 25, 2020
|
LGTM |
|
moving fast guys haha. need to get this release :) |
|
@williamFalcon I will create an issue to discuss the possibility for dict instead of namespace |
|
@awaelchli cool, could you link it here pls |
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
relax model loading hparams test wip wip fix warning finish test remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #907. Changes model loading behaviour. Four cases:
Case 0: Checkpoint has hparams key and user's LightningModule has hparams argument
no change
Case1: Checkpoint has hparams key and user's LightningModule is missing a hparams argument
Before: raised exception but did not tell user what's wrong
Now: raises exception reminding the user to add hparams.
Case 2: Checkpoint is missing hparams key and user's LightningModule is also missing it
Before: raised an exception
Now: Loads the model without hparams. This is the usecase in Relax hparams in model saving/loading #907.
Case 3: Checkpoint is missing hparams key but user's LightningModule has it.
Before: raised an exception
Now: Loads the model by passing in an empty Namespace and prints a warning.
All tests pass on my single gpu machine.
Some tests fail on my notebook (lazy_dataloader problem)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃