Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add epoch option to basic template #930

Closed
wants to merge 2 commits into from
Closed

add epoch option to basic template #930

wants to merge 2 commits into from

Conversation

baeseongsu
Copy link
Contributor

@baeseongsu baeseongsu commented Feb 25, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

If set up the default parser (#916 ), then we could use that one in general.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@baeseongsu baeseongsu closed this Feb 25, 2020
@baeseongsu baeseongsu deleted the develop branch February 25, 2020 01:52
@baeseongsu
Copy link
Contributor Author

I will take a closer look for my code. Sry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant