Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean docs #967

Merged
merged 4 commits into from
Feb 27, 2020
Merged

clean docs #967

merged 4 commits into from
Feb 27, 2020

Conversation

williamFalcon
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added the docs Documentation related label Feb 27, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 27, 2020
@williamFalcon williamFalcon merged commit ad80a7d into master Feb 27, 2020
@Borda
Copy link
Member

Borda commented Feb 27, 2020

now since #833 is merged we shall care about sphinx PR recommendations

@williamFalcon williamFalcon deleted the docs3 branch February 28, 2020 21:00
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
* clean docs

* clean docs

* clean docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants