Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auto_restore option to disable auto loading #972

Closed
wants to merge 2 commits into from

Conversation

Ir1d
Copy link
Contributor

@Ir1d Ir1d commented Feb 28, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #368 (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

I think no one is actually working on this, so i brought a pr.
As an hot fix, no breaking change is included.
Please get this solved asap. I'm fucked up by this auto loading..

@Ir1d
Copy link
Contributor Author

Ir1d commented Feb 28, 2020

@Borda @neggert @williamFalcon @ethanwharris please take a look

@williamFalcon
Copy link
Contributor

i was thinking that we would just get rid of it altogether?

@Ir1d
Copy link
Contributor Author

Ir1d commented Feb 28, 2020

+1 for get rid of them all.
But it seems would be a huge update in docs, tests etc. I see the examples are associated with this feature. Also, someone might be still depending on this feature. So for now, I'm introducing this option as an intermediate option.

@Borda
Copy link
Member

Borda commented Feb 28, 2020

I do not have any strong opinion about it, I understand the point resume from lat automatically but it can be dangerous if you have a bit mess in your logging folder so resuming from a specific checkpoint is better...

@Ir1d
Copy link
Contributor Author

Ir1d commented Feb 28, 2020

anyway, I've edit my local pl to remove the restore function.. Feel free to close this PR if you'd like to remove the loading at once.

it can be dangerous if you have a bit mess in your logging folder so resuming from a specific checkpoint is better...

Indeed, the logging behavior is hidden and not clearly logged, and it is called inside model.fit, which overwrites any initialization and my ckpt loading

@williamFalcon
Copy link
Contributor

yeah, let's remove it altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable automatic checkpoint loading
3 participants