Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove shaking phone as trigger for presentDebugMenu #2149

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

marionbarker
Copy link
Contributor

It is too easy to trigger the debug menu during daily phone use now that allowDebugFeatures is enabled for DIY loop.
Remove the shaking option, but keep the rotate phone between landscape and portrait 6 times with no more than 2 sec between rotations.

@elnjensen
Copy link
Contributor

Thanks for flagging this. I'll confirm that I accidentally trigger this almost daily, in normal use, so I'm in favor of making it harder to trigger accidentally.

@marionbarker
Copy link
Contributor Author

I tested this with a test phone.

  • Shake and see the menu every time
  • Apply patch, shake and do not see the menu
    • However, what I call the tick-tock approach - rotating my phone back and forth to landscape and portrait 3 times reliably brings up the menu

@Trpl7ca
Copy link

Trpl7ca commented Mar 29, 2024

Thanks hope it gets approved, that has been a nuisance

@Trpl7ca
Copy link

Trpl7ca commented Mar 30, 2024

It worked, thank you

@ps2 ps2 merged commit 6cf0285 into LoopKit:dev Apr 24, 2024
gestrich added a commit to gestrich/Loop that referenced this pull request May 3, 2024
… so no need to cherry-pick this the next time I build
gestrich added a commit to gestrich/LoopWorkspace that referenced this pull request May 3, 2024
…o dev so no need to cherry-pick this the next time I build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants