Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new sampling algorithm "mirostat" #142

Merged
merged 1 commit into from
May 5, 2023

Conversation

h3ndrik
Copy link

@h3ndrik h3ndrik commented May 5, 2023

This makes the (new) mirostat sampler from ggml-org#1126 available. There are more sampling techniques and features in that pull request.

I'm not sure if i implemented this correctly, so have a look at it before merging ;-) This only applies to llama.

@LostRuins
Copy link
Owner

this implementation is incorrect. Mirostat is a replacement for stochastic samplers and cannot be used alongside with them.

I plan to eventually add it as a command line flag, but I cannot support it within the Kobold API until it is implemented officially at https://github.com/henk717/KoboldAI

@LostRuins LostRuins added the invalid This doesn't seem right label May 5, 2023
@LostRuins LostRuins merged commit 851f553 into LostRuins:concedo May 5, 2023
@LostRuins
Copy link
Owner

I ended up merging it, but converting it to a launcher flag instead.

@LostRuins LostRuins removed the invalid This doesn't seem right label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants