Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #8

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Fix tests #8

merged 4 commits into from
Jul 17, 2024

Conversation

alexpott
Copy link
Collaborator

No description provided.

@alexpott
Copy link
Collaborator Author

The vendor/mink/driver-testsuite/tests/Js/SessionResetTest.php is failing because it was recently added to the generic test suite - see minkphp/driver-testsuite#96

@alexpott
Copy link
Collaborator Author

And the change being made here is analogous to minkphp/webdriver-classic-driver#27

@alexpott
Copy link
Collaborator Author

Note in order to pass this test needs Lullabot/php-webdriver#14 to be merged - so we can close windows

@justafish justafish merged commit 4de3353 into Lullabot:main Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants