allof, oneof, discriminator support #139
Merged
+965
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlimenkoAV
force-pushed
the
anklimenko/oneof-support
branch
from
124184f to
b892859
Compare
KlimenkoAV
force-pushed
the
anklimenko/oneof-support
branch
from
b892859 to
a4ad113
Compare
aleshchev
reviewed
Mar 25, 2024
src/swagger/OpenAPIService.ts
Outdated
| /** | ||
| * @description Gets refs from allof schema only one level down | ||
| */ | ||
| private getRefsByAllOf( |
There was a problem hiding this comment.
looks like totally copy paste from getRefsByObject. Can you combine methods
src/swagger/OpenAPIService.ts
Outdated
| @@ -203,6 +206,12 @@ export class OpenAPIService { | |||
| const expanded = this.expandRefs(refsFromObject, refKeys); | |||
| collectedRefs.push(...expanded); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
combine with isObject case
KlimenkoAV
force-pushed
the
anklimenko/oneof-support
branch
from
19e9dd2 to
e8a14d9
Compare
KlimenkoAV
force-pushed
the
anklimenko/oneof-support
branch
from
516b116 to
5e8a28d
Compare
|
Please increase the package version. |
aleshchev
reviewed
May 16, 2024
src/generators/utils/modelGuard.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| import { IExtendedInterfaceModel, InterfaceModel } from '../../models/InterfaceModel'; | |||
|
|
|||
There was a problem hiding this comment.
Why is it not in TypeGuard service ?
aleshchev
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.