Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes methods in MockNetworkService to open #11

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Changes methods in MockNetworkService to open #11

merged 3 commits into from
Jun 22, 2023

Conversation

roanutil
Copy link
Member

feature/improve-MockNetworkService-subclassing

@roanutil
Changes methods in MockNetworkService to open
b1aab05 
feature/improve-MockNetworkService-subclassing
@roanutil roanutil temporarily deployed to default June 21, 2023 18:11 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 18:11 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 18:12 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 18:12 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 18:12 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #11 (138ef06) into main (daf000a) will decrease coverage by 0.81%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   74.65%   73.84%   -0.81%     
==========================================
  Files          27       27              
  Lines         643      650       +7     
==========================================
  Hits          480      480              
- Misses        163      170       +7
Impacted Files Coverage Δ
Sources/NetworkService/URLRequest+HTTPHeader.swift 29.41% <0.00%> (-20.59%) ⬇️
.../NetworkServiceTestHelper/MockNetworkService.swift 95.83% <100.00%> (ø)

@roanutil
Add convenience property for getting an array of HTTPHeader as [Strin…
2f246fd 
…g: String]

feature/improve-MockNetworkService-subclassing
@roanutil roanutil temporarily deployed to default June 21, 2023 19:02 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 19:02 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 19:02 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 19:02 — with GitHub Actions Inactive
@roanutil
Run swiftformat
138ef06 
feature/improve-MockNetworkService-subclassing
@roanutil roanutil temporarily deployed to default June 21, 2023 19:03 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 19:03 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 19:03 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 19:03 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 21, 2023 19:03 — with GitHub Actions Inactive
@roanutil roanutil enabled auto-merge June 21, 2023 19:46
@roanutil roanutil merged commit 1949153 into main Jun 22, 2023
@roanutil roanutil deleted the feature/improve-MockNetworkService-subclassing branch June 30, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-mfb sam-mfb sam-mfb approved these changes

Assignees

@sam-mfb sam-mfb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roanutil @sam-mfb