Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/async beta does not support urlsessiondelegate #6

Merged

Conversation

roanutil
Copy link
Member

@roanutil roanutil commented Feb 8, 2023

  • Remove use of await URLSession.data as it does not support URLSessionDelegate
  • Run swiftformat
  • Update CI matrix
  • Update dependencies

…Delegate

bugfix/async-beta-does-not-support-urlsessiondelegate
bugfix/async-beta-does-not-support-urlsessiondelegate
bugfix/async-beta-does-not-support-urlsessiondelegate
bugfix/async-beta-does-not-support-urlsessiondelegate
@roanutil roanutil temporarily deployed to default February 8, 2023 22:13 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:13 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:13 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:13 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #6 (39a21c9) into main (c8ffdc2) will increase coverage by 1.37%.
The diff coverage is 70.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   75.22%   76.60%   +1.37%     
==========================================
  Files          50       50              
  Lines        1534     1530       -4     
==========================================
+ Hits         1154     1172      +18     
+ Misses        380      358      -22     
Impacted Files Coverage Δ
...es/NetworkService/HTTPURLResponse+StatusCode.swift 40.00% <ø> (ø)
Sources/NetworkService/NetworkService.swift 100.00% <ø> (ø)
...s/NetworkService/NetworkServiceClient+Delete.swift 100.00% <ø> (ø)
...rces/NetworkService/NetworkServiceClient+Get.swift 100.00% <ø> (ø)
...tworkService/NetworkServiceClient+GetSession.swift 100.00% <ø> (ø)
...ces/NetworkService/NetworkServiceClient+Post.swift 21.27% <ø> (ø)
...rces/NetworkService/NetworkServiceClient+Put.swift 34.78% <ø> (ø)
...es/NetworkService/NetworkServiceClient+Start.swift 80.00% <ø> (ø)
...vice/NetworkServiceClient+URLSessionDelegate.swift 0.00% <ø> (ø)
...rces/NetworkService/Publisher+NetworkService.swift 88.00% <ø> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@roanutil roanutil temporarily deployed to default February 8, 2023 22:17 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:17 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:17 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:17 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:17 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:19 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:19 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:19 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:19 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:19 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:19 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:21 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:21 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:21 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:21 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:22 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:22 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default February 8, 2023 22:22 — with GitHub Actions Inactive
@roanutil roanutil merged commit 71806bf into main Feb 8, 2023
@roanutil roanutil deleted the bugfix/async-beta-does-not-support-urlsessiondelegate branch February 8, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants