Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve mapping of errors #7

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

roanutil
Copy link
Member

@roanutil roanutil commented Mar 3, 2023

  • Try errors as URLError in Result.mapToNetworkError
  • Run swiftformat

roanutil added 2 commits March 3, 2023 15:46
feature/improve-mapping-of-errors
feature/improve-mapping-of-errors
@roanutil roanutil temporarily deployed to default March 3, 2023 21:47 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 3, 2023 21:47 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 3, 2023 21:47 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 3, 2023 21:47 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 3, 2023 21:47 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 3, 2023 21:47 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 3, 2023 21:47 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #7 (8975952) into main (71806bf) will decrease coverage by 0.18%.
The diff coverage is 81.81%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   76.60%   76.42%   -0.18%     
==========================================
  Files          50       50              
  Lines        1530     1527       -3     
==========================================
- Hits         1172     1167       -5     
- Misses        358      360       +2     
Impacted Files Coverage Δ
...kServiceAsyncBeta/NetworkServiceClient+Start.swift 76.00% <ø> (-0.48%) ⬇️
...etworkServiceAsyncBeta/Result+NetworkService.swift 79.41% <71.42%> (-6.70%) ⬇️
...HelperAsyncBetaTests/MockNetworkServiceTests.swift 98.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@roanutil roanutil merged commit 78a253d into main Mar 6, 2023
@roanutil roanutil deleted the feature/improve-mapping-of-errors branch March 24, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants