Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release async API and remove combine based API #8

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Conversation

roanutil
Copy link
Member

  • Replace primary targets with new async versions
  • Remove *AsyncBeta targets
  • Bump minimum Swift version from 5.3 to 5.5

@roanutil roanutil temporarily deployed to default March 23, 2023 17:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 23, 2023 17:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 23, 2023 17:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 23, 2023 17:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 23, 2023 17:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default March 23, 2023 17:32 — with GitHub Actions Inactive
@roanutil roanutil changed the title Async beta Release async API and remove combine based API Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #8 (e8269bf) into main (78a253d) will decrease coverage by 1.90%.
The diff coverage is 73.43%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   76.42%   74.53%   -1.90%     
==========================================
  Files          50       27      -23     
  Lines        1527      640     -887     
==========================================
- Hits         1167      477     -690     
+ Misses        360      163     -197     
Impacted Files Coverage Δ
Sources/NetworkService/NetworkService.swift 100.00% <ø> (ø)
Sources/NetworkService/Result+NetworkService.swift 79.41% <ø> (ø)
Sources/NetworkService/TopLevelCodable.swift 0.00% <0.00%> (ø)
Sources/NetworkService/URLRequest+build.swift 100.00% <ø> (ø)
...urces/NetworkServiceTestHelper/CodableOutput.swift 0.00% <ø> (ø)
Sources/NetworkServiceTestHelper/Delay.swift 80.00% <ø> (ø)
...urces/NetworkServiceTestHelper/FailureOutput.swift 0.00% <ø> (ø)
Sources/NetworkServiceTestHelper/MockOutput.swift 42.85% <ø> (ø)
...rces/NetworkServiceTestHelper/RepeatResponse.swift 100.00% <ø> (ø)
...ests/NetworkServiceTests/NetworkServiceTests.swift 43.75% <ø> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@roanutil roanutil merged commit 698fc3b into main Mar 24, 2023
@roanutil roanutil deleted the async-beta branch March 24, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants