Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict concurrency #11

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Strict concurrency #11

merged 7 commits into from
Feb 13, 2024

Conversation

roanutil
Copy link
Member

  • Bump minimum swift tools version to 5.8
  • Enable strict concurrency checking
  • Remove Xcode 14.2/Swift 5.7 and add Xcode 15.0/Swift 5.9 test strategies
  • Bump swiftformat Swift version to 5.8
  • Simplify Swift settings in manifest and add other Swift 6.0 settings
  • Run swiftformat (updated file header dates)

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee02af2) 81.34% compared to head (903e208) 81.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   81.34%   81.23%   -0.12%     
==========================================
  Files          23       23              
  Lines        1410     1407       -3     
==========================================
- Hits         1147     1143       -4     
- Misses        263      264       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -39,3 +41,16 @@ extension Package.Dependency {
extension Target.Dependency {
static let dependencies: Self = .product(name: "Dependencies", package: "swift-dependencies")
}

extension [SwiftSetting] {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more upcoming flags that aren't in this list. Did we want the full list here if this setting is going to mimic Swift 6.0? The 2 specifically I was looking at were:

https://github.com/apple/swift-evolution/blob/main/proposals/0413-typed-throws.md
https://github.com/apple/swift-evolution/blob/main/proposals/0418-inferring-sendable-for-methods.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those would require another increase in the minimum Swift version and may only be available in 5.10+. I don't think either of them would make much difference for this package anyway.

@r-jarvis r-jarvis merged commit f5a0682 into main Feb 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants