-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Unable to start electron with dev option on develop branch #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Suggestion, when it's fixed. Add a test case to verify it too ;-) |
I pushed #685 to resolv this case. @morozgrafix @qistoph do you have any approach how test this case? |
I was thinking something like this: However, just found out that this does not include run-start.sh in the e2e-test... |
Yes, this is work in layer inside the electron not the script run-start.sh. I seems good this test to me, later we can include a new for run-start.sh |
I think we can close this one after PR #711 goes through. |
@roramirez I believe that after PR #652
npm start dev
is no longer working on develop branch, becauserun-start.sh
doesn't processdev
parameter.The text was updated successfully, but these errors were encountered: