Skip to content

Unable to start electron with dev option on develop branch #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
morozgrafix opened this issue Feb 3, 2017 · 5 comments
Closed

Unable to start electron with dev option on develop branch #684

morozgrafix opened this issue Feb 3, 2017 · 5 comments

Comments

@morozgrafix
Copy link
Contributor

@roramirez I believe that after PR #652 npm start dev is no longer working on develop branch, because run-start.sh doesn't process dev parameter.

@qistoph
Copy link
Contributor

qistoph commented Feb 3, 2017

Suggestion, when it's fixed. Add a test case to verify it too ;-)

@roramirez
Copy link
Contributor

I pushed #685 to resolv this case.

@morozgrafix @qistoph do you have any approach how test this case?

@qistoph
Copy link
Contributor

qistoph commented Feb 5, 2017

I was thinking something like this:
qistoph@42f2211

However, just found out that this does not include run-start.sh in the e2e-test...

@roramirez
Copy link
Contributor

Yes, this is work in layer inside the electron not the script run-start.sh. I seems good this test to me, later we can include a new for run-start.sh

@morozgrafix
Copy link
Contributor Author

I think we can close this one after PR #711 goes through.

@MichMich MichMich closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants