Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change from 0.0.13->0.1.1 #52

Closed
alippai opened this issue Feb 9, 2020 · 2 comments · Fixed by #53
Closed

API change from 0.0.13->0.1.1 #52

alippai opened this issue Feb 9, 2020 · 2 comments · Fixed by #53

Comments

@alippai
Copy link

alippai commented Feb 9, 2020

The httptools 1.0.0 release notes say that there should be no breaking change, but upgrading httptools from version 0.0.13 breaks uvicorn tests:

PR: encode/uvicorn#569
Test: https://travis-ci.org/encode/uvicorn/jobs/647886597
@elprans
Copy link
Member

elprans commented Feb 9, 2020

You should NOT import anything from httptools.parser directly (that is private API). The only public API is whatever is available under httptools directly, including the exception classes.

elprans added a commit that referenced this issue Feb 9, 2020
@elprans
Fix httptools.__all__
5e819f4 
While looking at #52, I noticed that `httptools.__all__` is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52
@elprans elprans mentioned this issue Feb 9, 2020
Merged
@elprans
Copy link
Member

elprans commented Feb 9, 2020

#53 restores the behavior of 0.0.13, but please fix your code to not import anything from httptools submodules, we will make them private in a future release.

@alippai alippai mentioned this issue Feb 9, 2020
Closed
elprans added a commit that referenced this issue Feb 11, 2020
@elprans
Fix httptools.__all__
db497f9 
While looking at #52, I noticed that `httptools.__all__` is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52
elprans added a commit that referenced this issue Feb 29, 2020
@elprans
Fix httptools.__all__
9340d32 
While looking at #52, I noticed that `httptools.__all__` is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52
This was referenced Apr 23, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix httptools.__all__ MagicStack/httptools
2 participants
@alippai @elprans