Skip to content

Prevent const reassignment of GEMS_PENDING_ROOT #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2015

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jul 18, 2015

When launched through the vmdb application, GEM_PENDING_ROOT is already
set. This setup is mainly for testing and bootstrapping things in
gems/pending and will go away when they are gemified.

@chessbyte Please review.

@Fryguy Fryguy added the bug label Jul 18, 2015
When launched through the vmdb application, GEM_PENDING_ROOT is already
set.  This setup is mainly for testing and bootstrapping things in
gems/pending and will go away when they are gemified.
@Fryguy Fryguy force-pushed the guard_const_assignment branch from dc11fe1 to 366f009 Compare July 18, 2015 01:58
@miq-bot
Copy link
Member

miq-bot commented Jul 18, 2015

Checked commit Fryguy@366f009 with rubocop 0.32.0
1 file checked, 0 offenses detected
Everything looks good. 👍

chessbyte added a commit that referenced this pull request Jul 18, 2015
Prevent const reassignment of GEMS_PENDING_ROOT
@chessbyte chessbyte merged commit 180b855 into ManageIQ:master Jul 18, 2015
@chessbyte chessbyte self-assigned this Jul 18, 2015
@chessbyte chessbyte added this to the Sprint 27 Ending August 3, 2015 milestone Jul 18, 2015
@Fryguy Fryguy deleted the guard_const_assignment branch July 23, 2015 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants