-
Notifications
You must be signed in to change notification settings - Fork 126
Add RPC for latest checkpoint #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Brandon H. Gomes <[email protected]>
Signed-off-by: Brandon H. Gomes <[email protected]>
why a new RPC end-point? Should we just add the total number to the |
Signed-off-by: Shumo Chu <[email protected]>
This PR requires merging #723 first. |
Signed-off-by: Shumo Chu <[email protected]>
Signed-off-by: Shumo Chu <[email protected]>
Signed-off-by: Shumo Chu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got the same thought as @ghzlatarev in https://github.com/Manta-Network/Manta/pull/712/files#r935325448 that it would be cheaper to bump the total number in storage on each TX and read a StorageValue instead of collecting the 256 shards on every single rpc call.
Intuitively, it sounds far more computationally expensive to have 257 storage reads per RPC instead of 2, especially in light of the recently merged #469
I think this'll need proper benchmarking - or some caching in the #686 where it only pulls a new value from the RT once per block and serves the rest from cache.
If we do the latter thing this LGTM. @bhgomes could you pls open a followup issue? Nvm, just realized that the #686 indexer IS the followup issue
Yeah, we have discussed this. Will do it in the |
Signed-off-by: Brandon H. Gomes [email protected]
Description
Adds an RPC method for querying the latest checkpoint. This is useful for getting a loading bar for synchronization.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updated