Skip to content

Add MantaPay to Calamari runtime #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 6, 2022
Merged

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Nov 30, 2022

Signed-off-by: Georgi Zlatarev [email protected]

Description

  • Add MantaPay to Calamari runtime
  • Get rid of a few unwraps() and todos()

closes: #812
closes: #598


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev mentioned this pull request Nov 30, 2022
4 tasks
@ghzlatarev ghzlatarev self-assigned this Nov 30, 2022
@ghzlatarev ghzlatarev added A-calamari Area: Issues and PRs related to the Calamari Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition labels Nov 30, 2022
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev marked this pull request as ready for review December 5, 2022 09:05
@ghzlatarev ghzlatarev requested review from Garandor, stechu, Dengjianping and zqhxuyuan and removed request for stechu and Garandor December 5, 2022 09:07
@Dengjianping
Copy link
Contributor

@ghzlatarev Please add mantapay's rpc interface to calamari client.

@ghzlatarev
Copy link
Contributor Author

Linters are fixed in #904

Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ghzlatarev ghzlatarev merged commit a5c5e57 into manta Dec 6, 2022
@ghzlatarev ghzlatarev deleted the ghzlatarev/calamari-mantapay branch December 6, 2022 11:23
zqhxuyuan pushed a commit that referenced this pull request Dec 7, 2022
* Add MantaPay to Calamari runtime

Signed-off-by: Georgi Zlatarev <[email protected]>

* Use latest manta-rs

Signed-off-by: Georgi Zlatarev <[email protected]>

* Clean up manta-pay dependencies

Signed-off-by: Georgi Zlatarev <[email protected]>

* Fix linter

Signed-off-by: Georgi Zlatarev <[email protected]>

* Update mantapay weights

Signed-off-by: Georgi Zlatarev <[email protected]>

* Remove unwraps

Signed-off-by: Georgi Zlatarev <[email protected]>

* More iterations in tests

Signed-off-by: Georgi Zlatarev <[email protected]>

* Add mantapay's rpc interface to calamari client.

Signed-off-by: Georgi Zlatarev <[email protected]>

Signed-off-by: Georgi Zlatarev <[email protected]>
@Garandor Garandor mentioned this pull request Jan 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
3 participants