Skip to content

Catch UncaughtException for build and deploy #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

AgentHagu
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Fixes #2673

Similar details as #2592, there are missing process.exit() despite catching the error, leading to the code continuing on with an undefined rootFolder. The error message from #2592 was also reused.

Anything you'd like to highlight/discuss:

Testing instructions:
Try using the markbind build or markbind deploy commands in a non-MarkBind directory. The UncaughtException should be hidden and a user-friendly message should be displayed.

image

Proposed commit message: (wrap lines at 72 characters)
Catch UncaughtException for build and deploy


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link
Contributor

@gerteck gerteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The logged error messages are generic and relevant to both commands.

Copy link
Contributor

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We've seen similar issues before & this PR simply uses the same fixes we used back then, so there should not be issues. Thanks @AgentHagu!

@lhw-1 lhw-1 merged commit dd55cb2 into MarkBind:master Apr 1, 2025
8 checks passed
Copy link

github-actions bot commented Apr 1, 2025

@lhw-1 Each PR must have a SEMVER impact label, please remember to label the PR properly.

@lhw-1 lhw-1 added the r.Patch Version resolver: increment by 0.0.1 label Apr 2, 2025
@tlylt
Copy link
Contributor

tlylt commented Apr 2, 2025

@lhw-1 i think you are supposed to click the patch/minor/major in the pr description when you are going to approve the pr. There's an action to help add the label. I have seen you doing it manually a few times, just want to fyi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UncaughtException when using build or deploy in non-MarkBind directories
4 participants