Catch UncaughtException for build
and deploy
#2674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #2673
Similar details as #2592, there are missing
process.exit()
despite catching the error, leading to the code continuing on with an undefinedrootFolder
. The error message from #2592 was also reused.Anything you'd like to highlight/discuss:
Testing instructions:
Try using the
markbind build
ormarkbind deploy
commands in a non-MarkBind directory. The UncaughtException should be hidden and a user-friendly message should be displayed.Proposed commit message: (wrap lines at 72 characters)
Catch UncaughtException for
build
anddeploy
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):